Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace/CRD creation should happen before PreSync phase #4354

Closed
jessesuen opened this issue Sep 16, 2020 · 0 comments · Fixed by argoproj/gitops-engine#159
Closed

Namespace/CRD creation should happen before PreSync phase #4354

jessesuen opened this issue Sep 16, 2020 · 0 comments · Fixed by argoproj/gitops-engine#159
Assignees
@alexmt
Labels
enhancement New feature or request
Milestone
v1.8

Comments

@jessesuen
Copy link
Member

Summary

Namespace and CRD are special resources that need to be created before others, as they block creation of resources in that namespace or resources of that CRD kind. Therefore, these objects should be created before the PreSync phase (perhaps conditionally if we detect that there are PreSync resources in that namespace or of that CRD

Motivation

Some helm charts will create a CRD and CRs as a hook.
@jessesuen jessesuen added the enhancement New feature or request label Sep 16, 2020
@jessesuen jessesuen added this to the v1.8 milestone Sep 16, 2020
@jessesuen jessesuen changed the title Namespace/CRD creation should happen before PreSync phase Namespace/CRD creation should happen before PreSync phase Sep 16, 2020
@igorcezar igorcezar mentioned this issue Oct 8, 2020
Closed
@alexmt alexmt self-assigned this Oct 9, 2020
@alexmt alexmt mentioned this issue Oct 9, 2020
Merged
alexmt added a commit to alexmt/argo-cd that referenced this issue Oct 14, 2020
@alexmt
refactor: upgrade gitops-engine version ( argoproj#4354, argoproj#1787 )
853a423
@alexmt alexmt mentioned this issue Oct 14, 2020
Merged
alexmt pushed a commit that referenced this issue Oct 14, 2020
refactor: upgrade gitops-engine version ( #4354, #1787 ) (#4563)
8e11fac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmt alexmt

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.8
Development

Successfully merging a pull request may close this issue.

feat: Namespace/CRD creation should happen before PreSync phase alexmt/gitops-engine
2 participants
@alexmt @jessesuen