-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress indicators in Argo CD UI #4227
Comments
Hi Alex/Jesse, where do you want to see the progress indicator? Currently the sliding panel disappears after the sync button is pressed. |
Hello @keithchong , Probably the description is confusing. The progress indicator should be shown while PATCH/PUT API request is in progress. The Adding list of Argo CD pages that has the same issue and requires progress indicator. @keithchong , does it make sense? |
Hi @alexmt , yes, it makes sense. I'm also going to add the spinner to the Add Repo connection sliding panel. |
Yeah, I was looking at the code for the sync operation. If that sync panel did not disappear (I made it so it did not hide), then the spinner on the synchronize button could potentially cause confusion because it could imply it's for the whole sync operation, and it would stop, whereas the sync spinner on the application page was still spinning. I realized they are for two different things. |
Demo of enable/disable auto sync |
Demo of save |
Demo of connecting repo using HTTPS |
All three changes look great! Thank you @keithchong . Looking forward to the PR |
Hi @alexmt , could you assign this to me? I created the PR. Let me know if there could be other places you want a progress indicator. (I also looked at implementing a progress bar) |
Signed-off-by: Keith Chong <kykchong@redhat.com>
Summary
Argo CD UI provides the ability to edit/sync application, change project settings, generate token etc. In a real-life environment, each operation might take 1~2 seconds.
Motivation
The UI should show a progress indicator to provide visual feedback that the operation is in progress.
Proposal
Sync button that triggers app synchronization already has good progress icon:
Buttons that require progress indicator:
EditablePanel
component (used in multiple places).The text was updated successfully, but these errors were encountered: