fix: Resolved issue with kafka secret not returning SASL and TLS #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristoffer Olafsen <[email protected]>
|
|
Signed-off-by: Kristoffer Olafsen <[email protected]>
alexec
approved these changes
Jul 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 66.46% 66.18% -0.28%
==========================================
Files 60 60
Lines 829 834 +5
==========================================
+ Hits 551 552 +1
- Misses 231 234 +3
- Partials 47 48 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue with Kafka for runner. SASL and TLS is both needed to allow for
sasl_sslconnections.Also resolves issue #627
Signed-off-by: Kristoffer Olafsen [email protected]