Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove SunkMessages condition. Add sinks_total metric. #328

Merged
merged 6 commits into from
Sep 16, 2021
Merged

feat!: Remove SunkMessages condition. Add sinks_total metric. #328

merged 6 commits into from
Sep 16, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Sep 15, 2021 •
edited
Loading

Changes:

  • Improve the clarify to test logging, so it is easier to figure out how tests fail.
  • Change e2e from using data which is stored in step/status to /metrics in preparation for its removal.
  • Update the FMEA tests to also test sinks.

alexec
alexec commented Sep 16, 2021
View reviewed changes
test/metric.go Outdated Show resolved Hide resolved
alexec
alexec commented Sep 16, 2021
View reviewed changes
test/stan-fmea/stan_fmea_test.go
}

func TestStanFMEA_STANServiceDisruption(t *testing.T) {
t.SkipNow() // TODO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@alexec alexec marked this pull request as ready for review September 16, 2021 14:55
@alexec alexec requested a review from whynowy September 16, 2021 14:57
@alexec alexec merged commit 69e608a into main Sep 16, 2021
@alexec alexec deleted the tmp branch September 16, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy Awaiting requested review from whynowy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexec