fix: only calculate installed hash after changes have been applied

argoproj-labs · May 13, 2021 · 9172dc7 · 9172dc7
1 parent 0c055d2
commit 9172dc7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/controllers/bus/installer.go b/controllers/bus/installer.go
@@ -119,9 +119,6 @@ func (i installer) apply(ctx context.Context, namespace string, item *unstructur
 	if item.GetLabels() == nil {
 		item.SetLabels(map[string]string{})
 	}
-	annotations := item.GetAnnotations()
-	annotations[dfv1.KeyHash] = util.MustHash(item)
-	item.SetAnnotations(annotations)
 
 	labels := item.GetLabels()
 	labels["app.kubernetes.io/managed-by"] = "argo-dataflow"
@@ -177,6 +174,10 @@ func (i installer) apply(ctx context.Context, namespace string, item *unstructur
 		}
 	}
 
+	annotations := item.GetAnnotations()
+	annotations[dfv1.KeyHash] = util.MustHash(item)
+	item.SetAnnotations(annotations)
+
 	resourceInterface := i.resourceInterface(item, namespace)
 	if _, err := resourceInterface.Create(ctx, item, metav1.CreateOptions{}); err != nil {
 		if apierr.IsAlreadyExists(err) {