-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[ibmsm]: Add support for service_credentials secret type #629
base: main
Are you sure you want to change the base?
feat[ibmsm]: Add support for service_credentials secret type #629
Conversation
Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 72.16% 73.91% +1.74%
==========================================
Files 26 26
Lines 1994 1606 -388
==========================================
- Hits 1439 1187 -252
+ Misses 458 314 -144
- Partials 97 105 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's adding support for another secret type and it looks like it works like the others do, so no need to add to docs.
Thanks!
@werne2j could you please take a look at this PR? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just rebase the branch and then we can merge.
Signed-off-by: Jarek Gawor <[email protected]>
fa2dad5
to
86fdaa9
Compare
@werne2j updated now |
@werne2j one more ping :) |
@werne2j one more ping |
@werne2j and one more ping. |
@jkayani maybe you can merge? |
Description
Add support for
service_credentials
secret type.Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.21
to ensure only the minimum is pulled in.Type of Change
Other information