Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use region if path is full arn #487

Merged
merged 3 commits into from
Jun 18, 2023
Merged

feat: use region if path is full arn #487

merged 3 commits into from
Jun 18, 2023

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Apr 1, 2023

Description

Will use the region in from aws arn if the full arn is provided as a path

Fixes: #318

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023

Codecov Report

Merging #487 (23fa109) into main (20e99e9) will decrease coverage by 0.25%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   71.30%   71.06%   -0.25%     
==========================================
  Files          25       25              
  Lines        1903     1911       +8     
==========================================
+ Hits         1357     1358       +1     
- Misses        450      455       +5     
- Partials       96       98       +2     
Impacted Files Coverage Δ
pkg/backends/awssecretsmanager.go 61.11% <22.22%> (-8.46%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@werne2j werne2j merged commit 2f3a187 into main Jun 18, 2023
3 checks passed
@werne2j werne2j deleted the awsregion branch June 18, 2023 03:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants