GITOPS-1550 removed unnecessary roles/rolebindings for target namespace #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iam-veeramalla
approved these changes
Feb 11, 2022
2 tasks
wtam2018
added a commit
that referenced
this pull request
Mar 4, 2022
* Improve docs for custom roles feature (#548) * add route/ingress host to .status (#514) * fix: argocd-tls-certs-cm is overwritten on any change (#553) Signed-off-by: iam-veeramalla <[email protected]> * add docs for host field in .status (#554) * GITOPS-1550 removed unnecessary roles/rolebindings for target namespace (#557) * chore(deps): bump github.com/argoproj/argo-cd/v2 from 2.2.2 to 2.2.4 (#560) Bumps [github.com/argoproj/argo-cd/v2](https://github.com/argoproj/argo-cd) from 2.2.2 to 2.2.4. - [Release notes](https://github.com/argoproj/argo-cd/releases) - [Changelog](https://github.com/argoproj/argo-cd/blob/master/CHANGELOG.md) - [Commits](argoproj/argo-cd@v2.2.2...v2.2.4) --- updated-dependencies: - dependency-name: github.com/argoproj/argo-cd/v2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: update operator capabilities level in CSV (#549) * feat: bump argo cd to version 2.2.5 * feat: update bundle and manifests to v0.3.0 * Update deploy/olm-catalog/argocd-operator/0.2.0/argocd-operator.v0.2.0.clusterserviceversion.yaml Co-authored-by: jannfis <[email protected]> * Update config/manifests/bases/argocd-operator.clusterserviceversion.yaml Co-authored-by: jannfis <[email protected]> * Update bundle/manifests/argocd-operator.clusterserviceversion.yaml Co-authored-by: jannfis <[email protected]> Co-authored-by: Chetan Banavikalmutt <[email protected]> Co-authored-by: Regina Scott <[email protected]> Co-authored-by: Yi Cai <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jaideep Raghunath Rao <[email protected]> Co-authored-by: William Tam <[email protected]> Co-authored-by: jannfis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
When creating a namespace with the manage-by label it creates unnecessary dexServer and redisHa roles and roleBindings on the new namespace. The below namespace test doesn't need these roles/rolebindings.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes GITOPS-1550
How to test changes / Special notes to the reviewer:
$ oc get roles -n <target-namespace>$ oc get rolebindings -n <target-namespace>