Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: appset image fields not respected #1611

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: appset image fields not respected #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfc0469
add tests for bug: appset image fields not respected
anandrkskd Nov 27, 2024
2b5e6cf
fix assert files for tests
anandrkskd Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/k8s/1-045_validate_applicationset_image_override/01-add_applicationset_image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
name: example-argocd
labels:
example: basic
Comment on lines +1 to +6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
name: example-argocd
labels:
example: basic
apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
name: example-argocd

Lets remove the label and use v1beta api.

spec:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with what is expected here? Which image value will have high priority.

image: argocdimage
version: tag002
applicationSet:
image: testimage
version: tag001
10 changes: 10 additions & 0 deletions tests/k8s/1-045_validate_applicationset_image_override/01-assert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: example-argocd-applicationset-controller
spec:
template:
spec:
containers:
- image: "testimage:tag001"
name: argocd-applicationset-controller
10 changes: 10 additions & 0 deletions tests/k8s/1-045_validate_applicationset_image_override/02-assert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: example-argocd-applicationset-controller
spec:
template:
spec:
containers:
- image: "testimage:tag001"
name: argocd-applicationset-controller
11 changes: 11 additions & 0 deletions tests/k8s/1-045_validate_applicationset_image_override/02-remove_argocdcustom_image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
name: example-argocd
labels:
example: basic
spec:

Comment on lines +1 to +8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
name: example-argocd
labels:
example: basic
spec:
apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
name: example-argocd
spec:

Same as previous.

applicationSet:
image: testimage
version: tag001