Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS fo… #1577

Conversation

ishitasequeira
Copy link
Collaborator

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Cherry-pick #1574

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #? https://issues.redhat.com/browse/GITOPS-3465

How to test changes / Special notes to the reviewer:

…r dynamicScaling (argoproj-labs#1574)

* fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling

Signed-off-by: Ishita Sequeira <[email protected]>

* fix lint issues

Signed-off-by: Ishita Sequeira <[email protected]>

---------

Signed-off-by: Ishita Sequeira <[email protected]>
Copy link
Collaborator

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandf anandf merged commit 527994e into argoproj-labs:release-0.10 Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants