Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image updater changes git write back file #970

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

chengfang
Copy link
Collaborator

Fixes #963

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (70968a7) to head (74526c6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   72.42%   72.44%   +0.01%     
==========================================
  Files          27       27              
  Lines        3725     3727       +2     
==========================================
+ Hits         2698     2700       +2     
  Misses        885      885              
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis merged commit 14e60b8 into argoproj-labs:master Dec 18, 2024
10 checks passed
chengfang added a commit to chengfang/argocd-image-updater that referenced this pull request Dec 20, 2024
jannfis pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image updater helm chart 0.11.2 changes git write back file
3 participants