fix: delay setting git.username and git.email config till commit time #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Fang <[email protected]>
chengfang
force-pushed
the
git.username.git.email
branch
from
d3c1203 to
ab50856
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #912 +/- ##
=======================================
Coverage 74.70% 74.70%
=======================================
Files 31 31
Lines 3922 3922
=======================================
Hits 2930 2930
Misses 856 856
Partials 136 136 ☔ View full report in Codecov by Sentry. |
chengfang
added a commit
to chengfang/argocd-image-updater
that referenced
this pull request
Nov 8, 2024
…argoproj-labs#912) Signed-off-by: Cheng Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/argocd/git.go#L161-L167, it sets git.username and git.email config to the git client. These 2 configs are used by commit operation later. In some cases, the commit operation will not be needed, either because there are errors before the commit, or because the commit should be skipped due to absence of real changes.
This PR delays setting these 2 configs, which involves calling git command twice, till before the commit operation. In addition to the savings from skipping the 2 command calls, the logs will also be cleaner.