Skip to content

fix: missing namespace on clusterrolebinding in install manifests #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: missing namespace on clusterrolebinding in install manifests #860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
972f9a2
fix: missing namespace on clusterrolebinding in install manifests
chengfang Sep 9, 2024
812bfd3
Apply suggestions (indent the warning text) from code review
chengfang Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/install/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ Argo CD is running. Don't worry, without any configuration, it will not start me
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml
```

!!! warning
The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different
namespace then make sure to update the namespace reference.

!!!note "A word on high availability"
It is not advised to run multiple replicas of the same Argo CD Image Updater
instance. Just leave the number of replicas at 1, otherwise weird side
Expand Down Expand Up @@ -70,6 +74,10 @@ kubectl create namespace argocd-image-updater
kubectl apply -n argocd-image-updater -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml
```

!!! warning
The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different
namespace then make sure to update the namespace reference.

!!!note "A word on high availability"
It is not advised to run multiple replicas of the same Argo CD Image Updater
instance. Just leave the number of replicas at 1, otherwise weird side
Expand Down
1 change: 1 addition & 0 deletions manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ roleRef:
subjects:
- kind: ServiceAccount
name: argocd-image-updater
namespace: argocd
1 change: 1 addition & 0 deletions manifests/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ roleRef:
subjects:
- kind: ServiceAccount
name: argocd-image-updater
namespace: argocd
---
apiVersion: v1
kind: ConfigMap
Expand Down