-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting new value in Helm values file #838
Allow setting new value in Helm values file #838
Conversation
jnovick
commented
Aug 22, 2024
•
edited
Loading
edited
- This was previously supported, but broke when the function was refactored to preserve order of yaml file (Fix/helm values wbc #748)
- Behavior does not change if overriding an existing value
- If the values file is empty or does not have a previous value, add the value instead of erroring
104c19d
to
94ee4ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
==========================================
- Coverage 73.47% 73.46% -0.01%
==========================================
Files 31 31
Lines 3114 3128 +14
==========================================
+ Hits 2288 2298 +10
- Misses 692 694 +2
- Partials 134 136 +2 ☔ View full report in Codecov by Sentry. |
* This was previously supported, but broke when the function was refactored to preserve order of yaml file * Behavior does not change if overriding an existing value * If the values file is empty or does not have a previous value, add the value instead of erroring Signed-off-by: Joshua Novick <[email protected]>
94ee4ad
to
cd276ac
Compare
@jannfis I have published an image to my own registry and tested it works as desired and the tests also show that it works. Let me know if you want me to make any changes. @askhari If you have concerns, let me know since you implemented the change that broke the ability to write to a new file. I want to make sure you are aware in case this breaks a behavior that you are expecting. |
@jnovick , thank you for the notice :) . I see that now this fix is already merged. That's good news. Thank you for your help and improvement of the code :) . |
Signed-off-by: Joshua Novick <[email protected]> Signed-off-by: Tchoupinax <[email protected]>