Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade golangci-lint from v1.57.2 to v1.59.1; change golangci-lint vet to govet #819

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

chengfang
Copy link
Collaborator

To fix the warning with recent golangci-lint versions: WARN [lintersdb] The name "vet" is deprecated. The linter has been renamed to: govet.

golangci-lint v1.59.1:
https://github.com/golangci/golangci-lint/releases/tag/v1.59.1

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.92%. Comparing base (6686c9e) to head (a06c9c6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #819   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files          31       31           
  Lines        3140     3140           
=======================================
  Hits         2290     2290           
  Misses        716      716           
  Partials      134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis merged commit 555e07c into argoproj-labs:master Aug 7, 2024
10 checks passed
@chengfang chengfang deleted the golangci-lint.v1.59.1 branch August 7, 2024 14:44
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Tchoupinax pushed a commit to Tchoupinax/argocd-image-updater that referenced this pull request Oct 23, 2024
…langci-lint vet to govet (argoproj-labs#819)

Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants