fix: Improper parsing of image identifiers having both tag name and digest #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
==========================================
+ Coverage 67.97% 68.08% +0.11%
==========================================
Files 31 31
Lines 3135 3140 +5
==========================================
+ Hits 2131 2138 +7
+ Misses 856 855 -1
+ Partials 148 147 -1 ☔ View full report in Codecov by Sentry. |
|
@pasha-codefresh can you please review? Thanks. |
|
Oops. There is a conflict, can you please resolve it? |
…igest Signed-off-by: Cheng Fang <[email protected]>
chengfang
force-pushed
the
parsing.image.tag.digest
branch
from
85211d3 to
457999b
Compare
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…igest (argoproj-labs#815) Signed-off-by: Cheng Fang <[email protected]>
Tchoupinax
pushed a commit
to Tchoupinax/argocd-image-updater
that referenced
this pull request
Oct 23, 2024
…igest (argoproj-labs#815) Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Tchoupinax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #806