Fix updates to multiple images when using helm values file #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljupchokotev
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
ljupchokotev
force-pushed
the
fix-multi-image-helm
branch
2 times, most recently
from
2c2eb49
to
d7fa6de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #790 +/- ##
==========================================
+ Coverage 67.84% 67.97% +0.12%
==========================================
Files 31 31
Lines 3135 3135
==========================================
+ Hits 2127 2131 +4
+ Misses 860 856 -4
Partials 148 148 ☔ View full report in Codecov by Sentry. |
ljupchokotev
force-pushed
the
fix-multi-image-helm
branch
3 times, most recently
from
fca9928
to
9e7d8b9
Compare
chengfang
reviewed
Jul 18, 2024
When updating multiple images in a Helm values file, ArgoCD would only ever update a single image. This is because the code only takes into account the new helm values from the last image that it processed ignoring the changes for the previous images. This commit fixes that behavior. The `helmNewValues` var is moved outside of the for-loop that iterates over the app images. For each image, the tag is updated in the `helmNewValues` var. Signed-off-by: Lyupcho Kotev <[email protected]>
ljupchokotev
force-pushed
the
fix-multi-image-helm
branch
from
9e7d8b9
to
90eae75
Compare
chengfang
approved these changes
Jul 18, 2024
|
@ljupchokotev thanks! |
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…labs#790) Signed-off-by: Lyupcho Kotev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating multiple images in a Helm values file, ArgoCD would only ever update a single image. This is because the code only takes into account the new helm values from the last image that it processed ignoring the changes for the previous images.
This commit fixes that behavior. The
helmNewValuesvar is moved outside of the for-loop that iterates over the app images. For each image, the tag is updated in thehelmNewValuesvar.Fixes #786