chore: adding test coverage for NewClientMetrics & NewEndpointMetrics #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaque44 <[email protected]>
Signed-off-by: zhaque44 <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…argoproj-labs#743) * adding test coverage for NewClientMetrics & NewEndpointMetrics Signed-off-by: zhaque44 <[email protected]> * chore: forgot to run go tidy Signed-off-by: zhaque44 <[email protected]> --------- Signed-off-by: zhaque44 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances test coverage for the metrics package. Tests validate the proper initialization of endpoint and client metrics & scenarios with a Prometheus registry. Each test ensures:
NewEndpointMetrics and NewClientMetrics
are both correctly instantiated and their components (requestsTotal, requestsFailed, argoCDRequestsTotal, argoCDRequestsErrorsTotal, kubeAPIRequestsTotal, kubeAPIRequestsErrorsTotal) are properly initialized.