create github actions workflow init-release.yaml for preparing release #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannfis
reviewed
Jun 12, 2024
.github/workflows/init-release.yaml
Outdated
Comment on lines
84
to
89
| - name: Generate new set of manifests | ||
| run: | | ||
| set -ue | ||
| make manifests IMAGE_TAG="${{ env.TARGET_TAG }}" | ||
| git diff |
There was a problem hiding this comment.
For this to work, we will need kustomize installed on the GitHub runner
There was a problem hiding this comment.
Added a step to install kustomize:
- name: Install Kustomize
uses: imranismail/setup-kustomize@v2
with:
kustomize-version: '5.2.1'At the beginning of next step, echo the kustomize version. In test run, it prints the correct version:
kustomize version v5.2.1
Signed-off-by: Cheng Fang <[email protected]>
chengfang
force-pushed
the
release.workflow
branch
from
58ecc01 to
ecc2986
Compare
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
argoproj-labs#740) Signed-off-by: Cheng Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734
This PR adds a github actions on-demand workflow that contains necessary steps to prepare a release. This workflow is modelled after the script https://github.com/argoproj-labs/argocd-image-updater/blob/master/hack/release.sh, minus the last few steps in the end.
Note that this workflow only prepares the release, and the responsible release engineer is still responsible for verifying the output, and continue with further manual steps in order to finish the releasing.
A screenshot of the workflow input fields:
https://gist.github.com/chengfang/32f8c6f31fb0736476677abe1b8cc451
After a successful test run of the workflow in my fork, the following test PR in my fork was created:
chengfang#7