Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Git credentials work again #737

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jannfis
Copy link
Contributor

@jannfis jannfis commented Jun 7, 2024

Introduce the Git askpass helper that Argo CD's Git client uses in the meanwhile.

This PR includes some dirty workaounds that should be temporary (see code comments).

Fixes #735
Fixes #728

cmd/ask_pass.go Dismissed Show dismissed Hide dismissed
Signed-off-by: jannfis <[email protected]>
@pasha-codefresh
Copy link
Collaborator

@jannfis will go over it tomorrow

@jannfis jannfis merged commit a309127 into argoproj-labs:master Jun 14, 2024
10 checks passed
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
* fix: Make Git credentials work again

Signed-off-by: jannfis <[email protected]>

* Update

Signed-off-by: jannfis <[email protected]>

---------

Signed-off-by: jannfis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Updater not able to connect to Gitlab Repo terminal prompts disabled
3 participants