Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: git zombie processes left behind after periodic image updater runs #584

Merged
merged 1 commit into from
Jul 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ FROM alpine:latest

RUN apk update && \
apk upgrade && \
apk add ca-certificates git openssh-client python3 py3-pip && \
apk add ca-certificates git openssh-client python3 py3-pip tini && \
pip3 install --upgrade pip && \
pip3 install awscli && \
rm -rf /var/cache/apk/*
Expand All @@ -28,4 +28,4 @@ COPY hack/git-ask-pass.sh /usr/local/bin/git-ask-pass.sh

USER 1000

ENTRYPOINT ["/usr/local/bin/argocd-image-updater"]
ENTRYPOINT ["/sbin/tini", "--", "/usr/local/bin/argocd-image-updater"]
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ spec:
app.kubernetes.io/name: argocd-image-updater
spec:
containers:
- command:
- /usr/local/bin/argocd-image-updater
- args:
- run
image: quay.io/argoprojlabs/argocd-image-updater:latest
imagePullPolicy: Always
Expand Down