Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Error: Incorrect Usage of <image_name> in Annotations #581

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

geekloper
Copy link
Contributor

I have noticed an error in the documentation related to annotations. The documentation suggests using <image_name> instead of the correct placeholder <image_alias> when working with annotations ( Update strategies, Filtering tags, Ignoring certain tags, Image platforms & Specifying pull secrets ) . This mistake can potentially misguide users and cause confusion.

@codecov-commenter
Copy link

Codecov Report

Merging #581 (430b653) into master (5366cc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   65.86%   65.86%           
=======================================
  Files          22       22           
  Lines        2045     2045           
=======================================
  Hits         1347     1347           
  Misses        569      569           
  Partials      129      129           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis merged commit 568e6b9 into argoproj-labs:master Jul 6, 2023
ks-yim pushed a commit to ks-yim/argocd-image-updater that referenced this pull request Jul 9, 2023
jwhy89 pushed a commit to jwhy89/argocd-image-updater that referenced this pull request Aug 17, 2023
Co-authored-by: Abdellah Derfoufi <[email protected]>
Signed-off-by: Jarvis Yang <[email protected]>
xescab pushed a commit to xescab/argocd-image-updater that referenced this pull request Sep 8, 2023
Co-authored-by: Abdellah Derfoufi <[email protected]>
Signed-off-by: Francesc Arbona <[email protected]>
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants