Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name strategy regexp in example need to be correctd #534

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

iamraj007
Copy link
Contributor

Name strategy among Update strategies, have its example have a wrong regexp. Need correction to match format mentioned in last line YYYY-MM-DD. Current one is this format YYYY-MMDD (which is not what, doc wish to show)

Name strategy among Update strategies, have its example have a wrong regexp. Need correction to match format mentioned in last line `YYYY-MM-DD`. 
Current one is this format YYYY-MMDD (which is not what, doc wish to show)
@codecov-commenter
Copy link

Codecov Report

Merging #534 (a1365eb) into master (49825ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   65.76%   65.76%           
=======================================
  Files          21       21           
  Lines        2039     2039           
=======================================
  Hits         1341     1341           
  Misses        569      569           
  Partials      129      129           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iamraj007 iamraj007 changed the title Name strategy regexp in example need to be correctd Name strategy regexp in example need to be correctd Feb 17, 2023
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you for improving the docs!

LGTM.

@jannfis jannfis merged commit 4deeb5c into argoproj-labs:master Jun 8, 2023
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
…labs#534)

Name strategy among Update strategies, have its example have a wrong regexp. Need correction to match format mentioned in last line `YYYY-MM-DD`. 
Current one is this format YYYY-MMDD (which is not what, doc wish to show)
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
…labs#534)

Name strategy among Update strategies, have its example have a wrong regexp. Need correction to match format mentioned in last line `YYYY-MM-DD`. 
Current one is this format YYYY-MMDD (which is not what, doc wish to show)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants