Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Also request OCI media type image index #524

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

jannfis
Copy link
Contributor

@jannfis jannfis commented Jan 21, 2023

Fixes #522
Fixes #519

Signed-off-by: jannfis [email protected]

@jannfis jannfis merged commit fc2ceb4 into argoproj-labs:master Jan 21, 2023
jannfis added a commit that referenced this pull request Jan 21, 2023
@zoonoo
Copy link
Contributor

zoonoo commented Jan 25, 2023

@jannfis Thanks for the fix! Can you perhaps explain what happend? Did the specification used by registries change this week?

@jannfis
Copy link
Contributor Author

jannfis commented Jan 25, 2023

@zoonoo It seems some component or registry decided to change the outer layer manifests' media types for OCI type images. I am not fully aware about what happened, though.

mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Jan 26, 2023
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fetching metadata from Github Container Registry neither V1 or V2 or OCI manifest returned by registry
2 participants