-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update application config sample & replace the deprecated ioutil pkg #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 65.70% 65.70%
=======================================
Files 21 21
Lines 2041 2041
=======================================
Hits 1341 1341
Misses 571 571
Partials 129 129
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CaiYueTing
changed the title
docs: update application config sample
Fix: update application config sample & linter
Nov 10, 2022
CaiYueTing
changed the title
Fix: update application config sample & linter
Fix: update application config sample & replace the deprecated ioutil pkg
Nov 10, 2022
Signed-off-by: CaiYueTing <[email protected]>
Signed-off-by: CaiYueTing <[email protected]>
Signed-off-by: CaiYueTing <[email protected]>
jannfis
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This was referenced Nov 15, 2022
alexmt
pushed a commit
that referenced
this pull request
Dec 6, 2022
… pkg (#492) * docs: update application config sample Signed-off-by: CaiYueTing <[email protected]> * fix: use os read/write instead of deprecated ioutil read/write package Signed-off-by: CaiYueTing <[email protected]> * fix: use io, os pkg instead of all of the ioutil pkg Signed-off-by: CaiYueTing <[email protected]> Signed-off-by: CaiYueTing <[email protected]>
mcfearsome
pushed a commit
to mcfearsome/argocd-image-updater
that referenced
this pull request
Jan 26, 2023
… pkg (argoproj-labs#492) * docs: update application config sample Signed-off-by: CaiYueTing <[email protected]> * fix: use os read/write instead of deprecated ioutil read/write package Signed-off-by: CaiYueTing <[email protected]> * fix: use io, os pkg instead of all of the ioutil pkg Signed-off-by: CaiYueTing <[email protected]> Signed-off-by: CaiYueTing <[email protected]>
dlactin
pushed a commit
to dlactin/argocd-image-updater
that referenced
this pull request
May 9, 2024
… pkg (argoproj-labs#492) * docs: update application config sample Signed-off-by: CaiYueTing <[email protected]> * fix: use os read/write instead of deprecated ioutil read/write package Signed-off-by: CaiYueTing <[email protected]> * fix: use io, os pkg instead of all of the ioutil pkg Signed-off-by: CaiYueTing <[email protected]> Signed-off-by: CaiYueTing <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
… pkg (argoproj-labs#492) * docs: update application config sample Signed-off-by: CaiYueTing <[email protected]> * fix: use os read/write instead of deprecated ioutil read/write package Signed-off-by: CaiYueTing <[email protected]> * fix: use io, os pkg instead of all of the ioutil pkg Signed-off-by: CaiYueTing <[email protected]> Signed-off-by: CaiYueTing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR: