Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update application config sample & replace the deprecated ioutil pkg #492

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

CaiYueTing
Copy link
Contributor

@CaiYueTing CaiYueTing commented Nov 10, 2022

The PR:

  1. Update the sample url
  2. Fix the golang-ci-linter

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #492 (1bb16e2) into master (ccb749f) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files          21       21           
  Lines        2041     2041           
=======================================
  Hits         1341     1341           
  Misses        571      571           
  Partials      129      129           
Impacted Files Coverage Δ
pkg/argocd/git.go 64.84% <20.00%> (ø)
pkg/registry/config.go 82.14% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CaiYueTing CaiYueTing changed the title docs: update application config sample Fix: update application config sample & linter Nov 10, 2022
@CaiYueTing CaiYueTing changed the title Fix: update application config sample & linter Fix: update application config sample & replace the deprecated ioutil pkg Nov 10, 2022
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jannfis jannfis merged commit 1c35fc5 into argoproj-labs:master Nov 15, 2022
alexmt pushed a commit that referenced this pull request Dec 6, 2022
… pkg (#492)

* docs: update application config sample

Signed-off-by: CaiYueTing <[email protected]>

* fix: use os read/write instead of deprecated ioutil read/write package

Signed-off-by: CaiYueTing <[email protected]>

* fix: use io, os pkg instead of all of the ioutil pkg

Signed-off-by: CaiYueTing <[email protected]>

Signed-off-by: CaiYueTing <[email protected]>
mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Jan 26, 2023
… pkg (argoproj-labs#492)

* docs: update application config sample

Signed-off-by: CaiYueTing <[email protected]>

* fix: use os read/write instead of deprecated ioutil read/write package

Signed-off-by: CaiYueTing <[email protected]>

* fix: use io, os pkg instead of all of the ioutil pkg

Signed-off-by: CaiYueTing <[email protected]>

Signed-off-by: CaiYueTing <[email protected]>
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
… pkg (argoproj-labs#492)

* docs: update application config sample

Signed-off-by: CaiYueTing <[email protected]>

* fix: use os read/write instead of deprecated ioutil read/write package

Signed-off-by: CaiYueTing <[email protected]>

* fix: use io, os pkg instead of all of the ioutil pkg

Signed-off-by: CaiYueTing <[email protected]>

Signed-off-by: CaiYueTing <[email protected]>
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
… pkg (argoproj-labs#492)

* docs: update application config sample

Signed-off-by: CaiYueTing <[email protected]>

* fix: use os read/write instead of deprecated ioutil read/write package

Signed-off-by: CaiYueTing <[email protected]>

* fix: use io, os pkg instead of all of the ioutil pkg

Signed-off-by: CaiYueTing <[email protected]>

Signed-off-by: CaiYueTing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants