-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update golangci-lint version in CI #457
Merged
jannfis
merged 2 commits into
argoproj-labs:master
from
jaideepr97:update-golangci-lint
Jul 20, 2022
Merged
chore: update golangci-lint version in CI #457
jannfis
merged 2 commits into
argoproj-labs:master
from
jaideepr97:update-golangci-lint
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 65.60% 65.60%
=======================================
Files 21 21
Lines 2035 2035
=======================================
Hits 1335 1335
Misses 571 571
Partials 129 129 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
/approve |
jannfis
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alexmt
pushed a commit
that referenced
this pull request
Dec 6, 2022
* update golangci-lint version * update golangci-lint to v1.46.2
alexmt
pushed a commit
that referenced
this pull request
Dec 6, 2022
* update golangci-lint version * update golangci-lint to v1.46.2
alexmt
pushed a commit
that referenced
this pull request
Dec 6, 2022
* update golangci-lint version * update golangci-lint to v1.46.2
mcfearsome
pushed a commit
to mcfearsome/argocd-image-updater
that referenced
this pull request
Jan 26, 2023
* update golangci-lint version * update golangci-lint to v1.46.2
dlactin
pushed a commit
to dlactin/argocd-image-updater
that referenced
this pull request
May 9, 2024
* update golangci-lint version * update golangci-lint to v1.46.2
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
* update golangci-lint version * update golangci-lint to v1.46.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing on open PRs due to an older version of
golangci-lint
being usedAccording to golangci/golangci-lint#2374 older versions of golangci-lint are not compatible with go v1.18
Error message is:
This PR updates the version to
v1.46.2