Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Doc error --docker-server #442

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: Doc error --docker-server #442

merged 1 commit into from
Jul 20, 2022

Conversation

hawkesn
Copy link
Contributor

@hawkesn hawkesn commented Jun 4, 2022

Small fix, the flag --docker-registry is not a valid flag but --docker-server is.
Referring to the official Kubernetes documentation here: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/#create-a-secret-by-providing-credentials-on-the-command-line

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #442 (0fe3beb) into master (f12a5ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   65.60%   65.60%           
=======================================
  Files          21       21           
  Lines        2035     2035           
=======================================
  Hits         1335     1335           
  Misses        571      571           
  Partials      129      129           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and apologies for the late review!

LGTM.

@jannfis jannfis merged commit 66b1818 into argoproj-labs:master Jul 20, 2022
@hawkesn hawkesn deleted the fix/doc-error-authentication branch July 20, 2022 14:56
mcfearsome pushed a commit to mcfearsome/argocd-image-updater that referenced this pull request Jan 26, 2023
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants