feat: Automatic inferring of registry from image prefix #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…s#369) * feat: Infer registry from prefix Signed-off-by: jannfis <[email protected]> * Add missing registry testdata Signed-off-by: jannfis <[email protected]> * Correctly handle default registries Signed-off-by: jannfis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature allows the registry API to be inferred from an image's prefix. E.g. if the image name is
my.custom.registry/some/image, Argo CD Image Updater now won't require a dedicated configuration for the registrymy.custom.registry, but instead assume the Docker registry API's endpoint athttps://my.custom.registry/v2.This works as long as the API is available via HTTPS on the same host as the registry's prefix and as long as you won't need any custom configuration for your registry, such as modified TLS settings.
Signed-off-by: jannfis [email protected]