feat: support filtering apps by label in CLI #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannfis
reviewed
Jan 24, 2022
There was a problem hiding this comment.
Thanks @jaideepr97 - I have just two nits, please see below.
jaideepr97
force-pushed
the
filter-apps-by-labels
branch
from
a50c97f to
f4b4844
Compare
|
Thanks @jannfis |
jannfis
approved these changes
Jan 24, 2022
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #258
It adds a new CLI parameter
--match-application-labelwhich accepts a string label input to match applications againstIt currently only accepts a single label to filter against, and does not support pattern matching on label values, but those enhancements can be made in future PRs
steps to test out PR:
--match-application-labeland supply desired labelapplication should be updated with new image after sync