Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix inconsistency in the documentation on git write-back credentials #356

Merged
merged 1 commit into from
Jan 19, 2022
Merged

docs: Fix inconsistency in the documentation on git write-back credentials #356

merged 1 commit into from
Jan 19, 2022

Conversation

zoonoo
Copy link
Contributor

@zoonoo zoonoo commented Jan 19, 2022

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jannfis
jannfis approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for improving the docs, @zoonoo !

@jannfis jannfis changed the title Fix inconsistency in the documentation on git write-back credentials docs: Fix inconsistency in the documentation on git write-back credentials Jan 19, 2022
@jannfis jannfis merged commit a163f39 into argoproj-labs:master Jan 19, 2022
@jannfis jannfis mentioned this pull request Jan 19, 2022
Closed
@zoonoo zoonoo deleted the docs-credential-inconsistency branch January 19, 2022 08:35
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
@zoonoo @sribiere-jellysmack
docs: Fix inconsistency in the documentation on git write-back creden…
8388914 
…tials (argoproj-labs#356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoonoo @CLAassistant @jannfis