feat: Support manifestlist and multi-arch images #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
…r into feat/manifestlists
Signed-off-by: jannfis <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
* feat: Support manifestlist and multi-arch images Signed-off-by: jannfis <[email protected]> * Add unit test Signed-off-by: jannfis <[email protected]> * Fix linter issue Signed-off-by: jannfis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for manifest lists and platform-specific images (multi-arch images support).
By default, Image Updater now will only consider updating to images for the same platform as it is executed on (assuming single-platform clusters). The platforms to consider can be overridden per image using the
argocd-image-updater-argoproj.io/alias.platformannotation, which takes a comma-delimited list of platforms (e.g.linux/arm64orlinux/arm/v7).Notes:
For
latestanddigeststrategy, only images with matching platform will be considered for updateThe
semverandnamestrategies do not fetch meta data. These update strategies will not support multiple architectures. We may introduce complimentary strategies, which will support this (e.g.semver-multiarchandname-multiarch). However, the beauty ofsemverandnameare, that they don't need to fetch metadata in order to work.This PR does not contain documentation. Docs have yet to be written before 0.12.0 is being released.
Signed-off-by: jannfis [email protected]