fix: Fix registry authentication when URL has slash suffix #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
…r into fix/trim-registry-prefix-auth
Signed-off-by: jannfis <[email protected]>
jannfis
added a commit
that referenced
this pull request
Jan 7, 2022
* fix: Fix registry authentication when URL has slash suffix Signed-off-by: jannfis <[email protected]> * Fix format string Signed-off-by: jannfis <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…labs#331) * fix: Fix registry authentication when URL has slash suffix Signed-off-by: jannfis <[email protected]> * Fix format string Signed-off-by: jannfis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #329
Previously, when a registry's API URL was specified with a trailing slash, authentication would fail due to an invalid request being sent to the registry for the
/v2endpoint. This change removes any trailing slash from the URL before using it. Also, handle authentication errors early on.