fix: Invalid image reference format when using digest strategy with helm charts #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arts Signed-off-by: Agorgianitis Loukas <[email protected]>
|
|
jannfis
requested changes
Dec 15, 2021
There was a problem hiding this comment.
Thanks a lot, @elartista - this is useful!
I only have one cosmetic concern, please see below.
Also, can you please provide unit tests for the method?
|
Added unit tests, I believe this is now ready! |
jannfis
approved these changes
Dec 16, 2021
|
Waiting for this fix to be released. Do we have an ETA for a release that will include this fix? Thanks. |
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…elm charts (argoproj-labs#317) * fix: Invalid reference format when using digest strategy with helm charts Signed-off-by: Agorgianitis Loukas <[email protected]> * Rename image.GetFullTag() to image.GetTagWithDigest() for clarity * Add unit tests for image.GetTagWithDigest()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259 #210
When using digest update strategy, the helm image.tag parameter now composes a full tag of both the tag and the digest in the form:
This avoids invalid references in almost all helm charts that construct the image ref as
image.repository:image.tag, that so far resulted to the invalid references of the form: