feat: use HTTP_PROXY for registry endpoint #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jannfis
requested changes
Nov 18, 2021
There was a problem hiding this comment.
Thanks a lot for your contribution, @derdanne !
I think it would be easier to use http.ProxyFromEnvironment method for setting the Transport's proxy configuration, instead of rolling up our own logic for getting the environment. This would also have the benefit that https_proxy and no_proxy would be considered as well.
Reference can be found at: https://pkg.go.dev/net/http#ProxyFromEnvironment
|
Hey thanks for the feedback. I have switched to the http.ProxyFromEnvironment method. |
jannfis
changed the title
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…ined in environment (argoproj-labs#300)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use HTTP_PROXY in transport object for registry endpoint if defined in environment