Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update quoted true, false in configmap #298

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

manivannan-g
Copy link
Contributor

The non-quoted true, false variable assignment in the argocd-image-updater-config ConfigMap is causing failures. Quoted them now.

The non-quoted true, false variable assignment in the `argocd-image-updater-config` ConfigMap is causing failures. Quoted them now.
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2021

CLA assistant check
All committers have signed the CLA.

@jannfis jannfis changed the title Update quoted true, false in configmap docs: Update quoted true, false in configmap Nov 10, 2021
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @manivannan-g for improving the documentation!

@jannfis jannfis merged commit da58411 into argoproj-labs:master Nov 10, 2021
tuananh pushed a commit to tuananh/argocd-image-updater that referenced this pull request Nov 11, 2021
The non-quoted true, false variable assignment in the `argocd-image-updater-config` ConfigMap is causing failures. Quoted them now.
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
The non-quoted true, false variable assignment in the `argocd-image-updater-config` ConfigMap is causing failures. Quoted them now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants