feat: support managing Application CRD using K8S client (#140) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 68.12% 68.07% -0.05%
==========================================
Files 19 19
Lines 1302 1322 +20
==========================================
+ Hits 887 900 +13
- Misses 336 340 +4
- Partials 79 82 +3
Continue to review full report at Codecov.
|
alexmt
force-pushed
the
140-argo-k8s-client
branch
3 times, most recently
from
912c196 to
23296f1
Compare
…s#140) Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt
force-pushed
the
140-argo-k8s-client
branch
from
23296f1 to
70e1f91
Compare
jannfis
requested changes
Jan 25, 2021
cmd/main.go
Outdated
| var argoClient argocd.ArgoCD | ||
| switch cfg.ApplicationsAPIKind { | ||
| case applicationsAPIKindK8S: | ||
| argoClient = argocd.NewK8SClient(cfg.KubeClient) |
There was a problem hiding this comment.
Will this never return an error?
pkg/argocd/argocd.go
Outdated
|
|
||
| // NewAPIClient creates a new API client for ArgoCD and connects to the ArgoCD | ||
| // API server. | ||
| func NewK8SClient(kubeClient *kube.KubernetesClient) ArgoCD { |
There was a problem hiding this comment.
To be consistent with NewAPIClient, I think we should have the return value specified as (ArgoCD, error), even if we currently just return nil here.
There was a problem hiding this comment.
Agree, we might need to return error in a future. Applied your suggestion.
Signed-off-by: Alexander Matyushentsev <[email protected]>
5 tasks
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…s#140) (argoproj-labs#144) * feat: support managing Application CRD using K8S client (argoproj-labs#140) Signed-off-by: Alexander Matyushentsev <[email protected]> * apply review notes Signed-off-by: Alexander Matyushentsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev [email protected]
Closes #140
PR implements proposal from #140:
--argocd-namespaceflag--applications-api argocdflag (orAPPLICATIONS_APIenv variable).