Skip to content

Commit

Permalink
fix: git zombie processes left behind after periodic image updater ru…
Browse files Browse the repository at this point in the history 
…ns (#584)

Signed-off-by: Daniel Mavis <[email protected]>
  • Loading branch information
@dmavis
dmavis authored Jul 6, 2023
1 parent 7c93d60 commit f6c4fe3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ FROM alpine:latest

RUN apk update && \
apk upgrade && \
apk add ca-certificates git openssh-client python3 py3-pip && \
apk add ca-certificates git openssh-client python3 py3-pip tini && \
pip3 install --upgrade pip && \
pip3 install awscli && \
rm -rf /var/cache/apk/*
Expand All @@ -28,4 +28,4 @@ COPY hack/git-ask-pass.sh /usr/local/bin/git-ask-pass.sh

USER 1000

ENTRYPOINT ["/usr/local/bin/argocd-image-updater"]
ENTRYPOINT ["/sbin/tini", "--", "/usr/local/bin/argocd-image-updater"]
3 changes: 1 addition & 2 deletions manifests/base/deployment/argocd-image-updater-deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ spec:
app.kubernetes.io/name: argocd-image-updater
spec:
containers:
- command:
- /usr/local/bin/argocd-image-updater
- args:
- run
image: quay.io/argoprojlabs/argocd-image-updater:latest
imagePullPolicy: Always
Expand Down

1 comment on commit f6c4fe3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log for details.

Unrecognized words (1)

wildcards

Previously acknowledged words that are now absent mypass myuser otherapp wildcard wohoo :arrow_right:
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:argoproj-labs/argocd-image-updater.git repository
on the master branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/argoproj-labs/argocd-image-updater/actions/runs/5470480178/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (25) from .github/actions/spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:cpp/src/template-strings.txt 8 1
cspell:typescript/dict/typescript.txt 1098 1
cspell:software-terms/dict/softwareTerms.txt 1288 1
cspell:python/src/python/python-lib.txt 2417 1

Consider adding them (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/template-strings.txt
          cspell:typescript/dict/typescript.txt
          cspell:software-terms/dict/softwareTerms.txt
          cspell:python/src/python/python-lib.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml):

check_extra_dictionaries: ''
Errors (1)

See the 📜action log for details.

❌ Errors Count
❌ ignored-expect-variant 3

See ❌ Event descriptions for more information.

Please sign in to comment.