Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split node names for machines that use full node address #358

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

cms21
Copy link
Contributor

@cms21 cms21 commented Jun 6, 2023

This PR fixes serial mode on Polaris. The nodelist that serial mode would compare the local hostname to included the full node address, unlike the local hostname. We now split the node names and compare just the first part of the name to the local hostname.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.03 🎉

Comparison is base (9a02ef0) 60.89% compared to head (9f70b10) 60.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   60.89%   60.92%   +0.03%     
==========================================
  Files         157      157              
  Lines        9609     9610       +1     
  Branches     1255     1255              
==========================================
+ Hits         5851     5855       +4     
+ Misses       3501     3496       -5     
- Partials      257      259       +2     
Impacted Files Coverage Δ
balsam/_api/model.py 76.22% <0.00%> (ø)
balsam/config/config.py 81.37% <0.00%> (ø)
balsam/site/launcher/_serial_mode_worker.py 88.23% <66.66%> (-1.02%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cms21 cms21 merged commit 52f44d4 into main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants