Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyZMQ #302

Merged
merged 8 commits into from
Jan 6, 2023
Merged

Update PyZMQ #302

merged 8 commits into from
Jan 6, 2023

Conversation

keceli
Copy link
Contributor

@keceli keceli commented Dec 22, 2022

Current version of PyZMQ (22.3.0) doesn't work with Juypter. This PR:

  • updates PyZMQ to 24.0.1 and requires an exact match to this version to avoid similar problems with other dependencies.
  • Fixes static type checks with the new version.
  • Adds Python 3.10 to the CI.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Base: 61.54% // Head: 61.45% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (94406d9) compared to base (5704158).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   61.54%   61.45%   -0.09%     
==========================================
  Files         157      157              
  Lines        9477     9481       +4     
  Branches     1176     1218      +42     
==========================================
- Hits         5833     5827       -6     
- Misses       3390     3396       +6     
- Partials      254      258       +4     
Impacted Files Coverage Δ
balsam/site/launcher/_serial_mode_master.py 87.82% <100.00%> (ø)
balsam/site/launcher/_serial_mode_worker.py 88.17% <100.00%> (-1.08%) ⬇️
balsam/site/service/main.py 73.77% <0.00%> (-9.84%) ⬇️
balsam/platform/scheduler/lsf_sched.py 31.75% <0.00%> (-0.22%) ⬇️
balsam/server/main.py 70.00% <0.00%> (ø)
balsam/cmdline/utils.py 26.38% <0.00%> (ø)
balsam/cmdline/server.py 25.71% <0.00%> (ø)
balsam/server/routers/apps.py 100.00% <0.00%> (ø)
balsam/site/service/processing.py 31.75% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@keceli keceli requested a review from tomuram January 5, 2023 20:10
@tomuram tomuram merged commit 5c96bff into argonne-lcf:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants