cache indices support #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request refactors the dataset index building logic in
megatron/data/gpt_dataset.pyto improve modularity and add disk caching for index arrays. The changes introduce new internal helper functions, enhance logging, and optimize distributed loading of index files. The most important changes are grouped below:Dataset Index Building Refactor
_build_indices_blended,_build_indices_concat, and a new_build_indicesdispatcher for improved code clarity and maintainability. [1] [2]Disk Caching and Distributed Loading
_cache_indicesfunction that computes a hash of the dataset description, saves index arrays to disk, and loads them efficiently across distributed processes, reducing redundant computation and improving startup time.Logging and Messaging Improvements