Skip to content

fix: Call set_ccl_vars_on_aurora only if WORLD_SIZE > 1 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saforem2 merged 1 commit into from
Jan 28, 2025
Merged

fix: Call set_ccl_vars_on_aurora only if WORLD_SIZE > 1 #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 5 additions & 23 deletions ALCF/helpers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,29 +594,6 @@ setParams() {
else
FLASH_ARG="--use-flash-attn-builder"
fi
#### [sam: 08/17/2024] ##########################################
# Use best set of CCL env vars from Gordon Bell runs on Aurora
set_ccl_vars_on_aurora
#################################################################
#### [sam: 06/20/2024] ###############################################
# export CCL_PROCESS_LAUNCHER=pmix
# export CCL_ATL_TRANSPORT=mpi
# !XXX: USE KEY VALUE STORE FIX ON AURORA [2024-06-20]
# use_kvs_fix_on_aurora # <-- why are these different from those in update_ccl_env_vars_aurora ??
# update_ccl_env_vars_aurora
######################################################################
# if [[ -z "${USE_FLASH_ATTN:-}" ]]; then
# # NOTE: if NO_FLASH_ATTN is NON-empty; then NO FLASH ATTN !!
# export NO_FLASH_ATTN=1 # disabled on [2024-06-20] waiting on fix...
# if [[ -n "${NO_FLASH_ATTN-}" ]]; then
# echo "Not using flash-attn!!"
# else
# FLASH_ARG="--use-flash-attn-builder"
# fi
# else
# echo "Using flash-attn !!"
# FLASH_ARG="--use-flash-attn-builder"
# fi
# [Polaris]
elif [[ "${mn}" == "polaris" || "${mn}" == "sirius" ]]; then
# export LAUNCH_CMD="${LAUNCH_CMD:-deepspeed}"
Expand Down Expand Up @@ -679,6 +656,11 @@ setParams() {
fi
export NGPU_PER_HOST="${NGPU_PER_HOST}"
export WORLD_SIZE="${WORLD_SIZE:-$((NHOSTS * NGPU_PER_HOST))}"
if [[ "${WORLD_SIZE}" -gt 1 && "${mn}" == "aurora" ]]; then
#### [sam: 08/17/2024] ##########################################
# Use best set of CCL env vars from Gordon Bell runs on Aurora
set_ccl_vars_on_aurora
fi
# +---[Llama2 7B Config]--------------------------------------------------+
# export MODEL_KEY="Llama-7B"
export HEADS=${HEADS:-${NHEADS:-32}} # NUMBER OF ATEN HEADS
Expand Down