-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirements
list for Pipeline
#720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #720 will not alter performanceComparing Summary
|
…ionality for Step and BasePipeline
…to pipeline-requirements
plaguss
requested review from
gabrielmbmb and
alvarobartt
and removed request for
gabrielmbmb
June 13, 2024 13:13
gabrielmbmb
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…to pipeline-requirements
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
…/distilabel into pipeline-requirements
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
…id reinstantiation
gabrielmbmb
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
…ue to requirements not installed
gabrielmbmb
changed the title
Add requirements list for a pipeline
Add Jun 27, 2024
requirements
list for Pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new attribute to
requirements
toBasePipeline
to keep track of the dependencies needed to run aPipeline
. Thepipeline.dump()
method now contains a new key with the requirements, if any.We can include requirements at the
Pipeline
level, and ideally we would add requirements for custom steps via@requirements
decorator, to avoid making the step definition more verbose.It will throw a
ValueError
before running and show the dependencies that aren't already installed in your environment.