Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Pass verify (and other transport args) when creating the argilla client #5789

Merged
merged 5 commits into from
Jan 21, 2025
Merged

[BUGFIX] Pass verify (and other transport args) when creating the argilla client #5789

merged 5 commits into from
Jan 21, 2025

Conversation

frascuchon
Copy link
Member

Description

Closes #5548

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon linked an issue Jan 21, 2025 that may be closed by this pull request
[BUG-python/deployment] [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate #5548
Closed
@frascuchon frascuchon mentioned this pull request Jan 21, 2025
Closed
davidberenstein1957
davidberenstein1957 reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM, one small remark.

argilla/src/argilla/_api/_http/_client.py Outdated Show resolved Hide resolved
frascuchon and others added 2 commits January 21, 2025 11:38
@frascuchon
extract transport args from init
c65c5c6
@frascuchon
Merge branch 'develop' into 5548-bug-pythondeployment-ssl-certificate…
1593ef8 
…_verify_failed-certificate-verify-failed-unable-to-get-local-issuer-certificate
@frascuchon frascuchon merged commit 045dec2 into develop Jan 21, 2025
7 checks passed
@frascuchon frascuchon deleted the 5548-bug-pythondeployment-ssl-certificate_verify_failed-certificate-verify-failed-unable-to-get-local-issuer-certificate branch January 21, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frascuchon @davidberenstein1957