-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] [ENHANCEMENT] create users and workspaces with predefined ID #5786
[BUGFIX] [ENHANCEMENT] create users and workspaces with predefined ID #5786
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5786 +/- ##
===========================================
+ Coverage 91.94% 91.95% +0.01%
===========================================
Files 161 161
Lines 6918 6927 +9
===========================================
+ Hits 6361 6370 +9
Misses 557 557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frascuchon, looks good.
I would also update the API ref docs but I think we can leave the how to guides as is for simplicity.
- argilla/docs/reference/argilla/users.md
- argilla/docs/reference/argilla/workspaces.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also update the API ref docs but I think we can leave the how to guides as is for simplicity.
argilla/docs/reference/argilla/users.md
argilla/docs/reference/argilla/workspaces.md
The ref docs are quite base, they omit other relevant attributes such as role. I prefer not to touch them. I've included more info in the init args description to reflect this new feature. |
Description
This PR allows users and workspaces to be created with predefined IDs. Passing a predefined ID when creating workspaces and users simplifies the migration process since users don't need to review responses and map them to new users, avoiding potential issues in the process.
Type of change
How Has This Been Tested
Checklist