[ENHANCEMENT] argilla server: Return users on dataset progress
#5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when creating responses
…argilla-io/argilla into feat/argilla-server/track-dataset-users
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5701 +/- ##
===========================================
+ Coverage 91.79% 91.95% +0.16%
===========================================
Files 161 161
Lines 6738 6750 +12
===========================================
+ Hits 6185 6207 +22
+ Misses 553 543 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
frascuchon
changed the title
argilla server: Return users on dataset progressargilla server: Return users on dataset progress
frascuchon
commented
Nov 21, 2024
argilla-server/src/argilla_server/alembic/versions/580a6553186f_add_datasets_users_table.py
Show resolved
Hide resolved
jfcalvo
requested changes
Nov 21, 2024
argilla-server/src/argilla_server/alembic/versions/580a6553186f_add_datasets_users_table.py
Show resolved
Hide resolved
argilla-server/src/argilla_server/alembic/versions/580a6553186f_add_datasets_users_table.py
Outdated
Show resolved
Hide resolved
argilla-server/src/argilla_server/alembic/versions/580a6553186f_add_datasets_users_table.py
Outdated
Show resolved
Hide resolved
argilla-server/src/argilla_server/alembic/versions/580a6553186f_add_datasets_users_table.py
Show resolved
Hide resolved
argilla-server/src/argilla_server/alembic/versions/580a6553186f_add_datasets_users_table.py
Outdated
Show resolved
Hide resolved
argilla-server/src/argilla_server/alembic/versions/580a6553186f_add_datasets_users_table.py
Outdated
Show resolved
Hide resolved
| ) -> Sequence[User]: | ||
| query = select(DatasetUser).filter_by(dataset_id=dataset.id).options(selectinload(DatasetUser.user)) | ||
|
|
||
| result = await db.scalars(query.order_by(DatasetUser.inserted_at.asc())) |
There was a problem hiding this comment.
You can move the order_by to the query.
Co-authored-by: José Francisco Calvo <[email protected]>
frascuchon
commented
Nov 21, 2024
jfcalvo
approved these changes
Nov 21, 2024
frascuchon
added a commit
that referenced
this pull request
Nov 27, 2024
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adds support to return a list of usernames in the dataset progress endpoint. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: José Francisco Calvo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to return a list of usernames in the dataset progress endpoint.
Type of change
How Has This Been Tested
Checklist