Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] argilla server: Prevent passing non-string values to text fields #5682

Conversation

frascuchon
Copy link
Member

Description

This PR prevents creating records with non-string values for text fields. Currently, users can create records with dictionary values as values for text fields.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from jfcalvo November 11, 2024 12:45
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (f47f20d) to head (19ff998).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5682      +/-   ##
===========================================
+ Coverage    91.55%   91.56%   +0.01%     
===========================================
  Files          165      165              
  Lines         6675     6686      +11     
===========================================
+ Hits          6111     6122      +11     
  Misses         564      564              
Flag Coverage Δ
argilla-server 91.56% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@frascuchon frascuchon added this to the v2.5.0 milestone Nov 14, 2024
@frascuchon frascuchon merged commit 0b5b009 into develop Nov 20, 2024
6 checks passed
@frascuchon frascuchon deleted the bugfixes/argilla-server/validate-field-value-for-text-fields branch November 20, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants