Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get default workspace if exits when creating default user #5558

Conversation

frascuchon
Copy link
Member

Description

This PR fixes the create_default CLI command errors when creating a default user and the default workspace already exists.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon added this to the v2.3.0 milestone Oct 2, 2024
@frascuchon frascuchon requested a review from jfcalvo October 2, 2024 11:16
@frascuchon frascuchon self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (3032d3a) to head (84b20ff).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5558      +/-   ##
===========================================
+ Coverage    91.22%   91.24%   +0.01%     
===========================================
  Files          145      145              
  Lines         5972     5973       +1     
===========================================
+ Hits          5448     5450       +2     
+ Misses         524      523       -1     
Flag Coverage Δ
argilla-server 91.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon merged commit a150b55 into develop Oct 2, 2024
1 of 2 checks passed
@frascuchon frascuchon deleted the bugfix/argilla-server/create-default-user-when-default-workspace-exists branch October 2, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants