[BUGFIX] serialize-chat-fields #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
frascuchon
reviewed
Oct 2, 2024
Comment on lines
+305
to
+314
| for key, value in self.items(): | ||
| if value is None: | ||
| continue | ||
| elif self._is_image(key): | ||
| fields[key] = cast_image(value) | ||
| elif self._is_chat(key): | ||
| fields[key] = [message.model_dump() if not isinstance(message, dict) else message for message in value] | ||
| else: | ||
| fields[key] = value | ||
| return fields |
There was a problem hiding this comment.
We need to review all the serialization logic when addressing #4944.
We have a serialization logic broken down by the code and we are not sure which will apply for each case.
frascuchon
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #<issue_number>
Type of change
How Has This Been Tested
Checklist