[BUGFIX] argilla: improve from_hub robustness
#5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A default question will be create if no question at all - All questions are optional except the first one - Avoid generate extra questions/metadata duplicated from the same feature
davidberenstein1957
approved these changes
Sep 24, 2024
for more information, see https://pre-commit.ci
…github.com/argilla-io/argilla into feat/argilla/improve-from-hub-capabilities
for more information, see https://pre-commit.ci
dvsrepo
reviewed
Sep 24, 2024
dvsrepo
reviewed
Sep 24, 2024
dvsrepo
reviewed
Sep 24, 2024
…github.com/argilla-io/argilla into feat/argilla/improve-from-hub-capabilities
for more information, see https://pre-commit.ci
…github.com/argilla-io/argilla into feat/argilla/improve-from-hub-capabilities
for more information, see https://pre-commit.ci
frascuchon
commented
Sep 24, 2024
frascuchon
commented
Sep 24, 2024
for more information, see https://pre-commit.ci
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #<issue_number> **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <[email protected]>
frascuchon
changed the title
argilla: improve from hub capabilitiesargilla: improve from_hub robustness
burtenshaw
approved these changes
Sep 25, 2024
frascuchon
added a commit
that referenced
this pull request
Sep 25, 2024
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adds some changes in how settings are built from the dataset features: - All questions are optional except the first one - Avoid generating extra questions/metadata duplicated from the same feature - A default question will be created if there is no question at all Also, add robustness to the process with the following changes: - Sanitize settings and dataset name according to the server validation - Skip features with unsupported names (after sanitizing) - Allow passing subset dataset configuration for HF datasets. These changes result in datasets in Argilla with a data structure more similar to the original one. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Ben Burtenshaw <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: burtenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some changes in how settings are built from the dataset features:
Also, add robustness to the process with the following changes:
These changes result in datasets in Argilla with a data structure more similar to the original one.
Type of change
How Has This Been Tested
Checklist