Skip to content

[CHORE] Argilla: remove pydantic warnings #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

frascuchon
Copy link
Member

Description

This PR removes some pydantic usage warnings, changing the class Config definition to the ConfigDict instance attribute.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the base branch from develop to feat/v2.0.0 June 14, 2024 09:25
@frascuchon frascuchon requested a review from burtenshaw June 14, 2024 09:25
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5025-ki24f765kq-no.a.run.app

@frascuchon frascuchon merged commit 2b084f9 into feat/v2.0.0 Jun 18, 2024
3 of 4 checks passed
@frascuchon frascuchon deleted the chore/argilla/remove-pydantic-warnings branch June 18, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants